Github user haoch commented on the issue:

    https://github.com/apache/incubator-eagle/pull/331
  
    I think the implementation is to provide the foundation for make sure the 
code modules extensible, as how much code developer should write it's to 
continue simplifying the interface or DSL. I was told to think interface 
earlier than implementation.
    
    > - Further, what if the application needs know configuration for eagle 
server
    
    We should follow the defined interface of Application. For Application 
standalone mode, the configuration should be passed through configuration file, 
for Application managed by server, the configuration should be passed through: 
https://github.com/apache/incubator-eagle/blob/develop/eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationContext.java#L70
    
        this.config = 
ConfigFactory.parseMap(executionConfig).withFallback(envConfig);
    
    For managed classes, it could easily get server config by `@Inject Config 
config;`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to