[ 
https://issues.apache.org/jira/browse/EAGLE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428850#comment-15428850
 ] 

Edward Zhang commented on EAGLE-487:
------------------------------------

different createInjector will separate different implementations for one 
interface. This would cause multiple instances.

> use guice module better in app framework
> ----------------------------------------
>
>                 Key: EAGLE-487
>                 URL: https://issues.apache.org/jira/browse/EAGLE-487
>             Project: Eagle
>          Issue Type: Improvement
>    Affects Versions: v0.5.0
>            Reporter: Edward Zhang
>            Assignee: Edward Zhang
>             Fix For: v0.5.0
>
>
> There are multiple issues with using guice module in app framework.
> 1. ApplicationProviderServiceImpl is instantiated twice
> 2. the interface between application and eagle server is not clear. It is not 
> correct to only let application to register submodules,, instead it should 
> includes some state inherited from eagle server, for example metadata storage 
> type.
> 3. not necessary to use module scope, it is pretty over-engineering when 
> application only want to register some module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to