[
https://issues.apache.org/jira/browse/EAGLE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429519#comment-15429519
]
ASF GitHub Bot commented on EAGLE-487:
--------------------------------------
GitHub user yonzhang opened a pull request:
https://github.com/apache/incubator-eagle/pull/368
use guice module better in app framework
https://issues.apache.org/jira/browse/EAGLE-487
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yonzhang/incubator-eagle develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/368.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #368
----
commit 84c25978fd3eae18f19ba4010b21402699e92fba
Author: yonzhang <[email protected]>
Date: 2016-08-20T21:31:00Z
use guice module better in app framework
----
> use guice module better in app framework
> ----------------------------------------
>
> Key: EAGLE-487
> URL: https://issues.apache.org/jira/browse/EAGLE-487
> Project: Eagle
> Issue Type: Improvement
> Affects Versions: v0.5.0
> Reporter: Edward Zhang
> Assignee: Edward Zhang
> Fix For: v0.5.0
>
>
> There are multiple issues with using guice module in app framework.
> 1. ApplicationProviderServiceImpl is instantiated twice
> 2. the interface between application and eagle server is not clear. It is not
> correct to only let application to register submodules,, instead it should
> includes some state inherited from eagle server, for example metadata storage
> type.
> 3. not necessary to use module scope, it is pretty over-engineering when
> application only want to register some module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
