[
https://issues.apache.org/jira/browse/EAGLE-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470519#comment-15470519
]
ASF GitHub Bot commented on EAGLE-432:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/412#discussion_r77813561
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/impl/ApplicationManagementServiceImpl.java
---
@@ -112,14 +112,41 @@ public ApplicationEntity
uninstall(ApplicationOperations.UninstallOperation oper
ApplicationContext applicationContext = new ApplicationContext(
applicationProviderService.getApplicationProviderByType(applicationEntity.getDescriptor().getType()).getApplication(),
applicationEntity,config, alertMetadataService);
- // TODO: Check status, skip stop if already STOPPED
+ // TODO: Check status
try {
- applicationContext.onStop();
+ ApplicationEntity.Status status =
applicationEntity.getStatus();
+ switch (status){
+ case STARTING: {
+ LOGGER.info("application is starting, please try it
latter");
--- End diff --
Directly thrown out exception when status is not correct.
> Application status monitoring
> -----------------------------
>
> Key: EAGLE-432
> URL: https://issues.apache.org/jira/browse/EAGLE-432
> Project: Eagle
> Issue Type: Improvement
> Affects Versions: v0.5.0
> Reporter: Edward Zhang
> Assignee: DanielZhou
> Fix For: v0.5.0
>
>
> App framework needs to probe application status periodically or on demand.
> ApplicationEntity contains status field, and this field's value should come
> from physical storm applications.
> We can start background threads to check application status or on-demand.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
