[
https://issues.apache.org/jira/browse/EAGLE-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470529#comment-15470529
]
ASF GitHub Bot commented on EAGLE-432:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/412#discussion_r77814146
--- Diff:
eagle-server/src/main/java/org/apache/eagle/server/ServerApplication.java ---
@@ -69,5 +78,11 @@ public void run(ServerConfig configuration, Environment
environment) throws Exce
// context listener
environment.servlets().addServletListeners(new
CoordinatorListener());
+
+ // run application status service in background
Guice.createInjector(new CommonGuiceModule(),new ApplicationGuiceModule(), new
MemoryMetadataStore());
+ Injector injector = guiceBundle.getInjector();
+ ApplicationStatusUpdateService applicationStatusUpdateService =
injector.getInstance(ApplicationStatusUpdateService.class);
+ Managed updateAppStatusTask = new
ApplicationTask(applicationStatusUpdateService);
+ environment.lifecycle().manage(updateAppStatusTask);
--- End diff --
Correct approach to run status check service as a managed task!
> Application status monitoring
> -----------------------------
>
> Key: EAGLE-432
> URL: https://issues.apache.org/jira/browse/EAGLE-432
> Project: Eagle
> Issue Type: Improvement
> Affects Versions: v0.5.0
> Reporter: Edward Zhang
> Assignee: DanielZhou
> Fix For: v0.5.0
>
>
> App framework needs to probe application status periodically or on demand.
> ApplicationEntity contains status field, and this field's value should come
> from physical storm applications.
> We can start background threads to check application status or on-demand.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
