100pah commented on a change in pull request #9918: fix(pie): expansion
animation when first data is "-"
URL: https://github.com/apache/incubator-echarts/pull/9918#discussion_r256763116
##########
File path: src/chart/pie/pieLayout.js
##########
@@ -80,19 +80,7 @@ export default function (seriesType, ecModel, api, payload)
{
data.each(valueDim, function (value, idx) {
var angle;
if (isNaN(value)) {
- data.setItemLayout(idx, {
- angle: NaN,
- startAngle: NaN,
- endAngle: NaN,
- clockwise: clockwise,
- cx: cx,
- cy: cy,
- r0: r0,
- r: roseType
- ? NaN
- : r
- });
- return;
+ value = 0;
Review comment:
@pissang mentioned that if set value as `0`, border still exists, which is
not expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
