100pah commented on a change in pull request #9918: fix(pie): expansion
animation when first data is "-"
URL: https://github.com/apache/incubator-echarts/pull/9918#discussion_r256752033
##########
File path: src/chart/pie/labelLayout.js
##########
@@ -176,7 +176,7 @@ export default function (seriesModel, r, viewWidth,
viewHeight, sum) {
var labelLineLen = labelLineModel.get('length');
var labelLineLen2 = labelLineModel.get('length2');
- if (layout.angle < minShowLabelRadian) {
+ if (layout.angle < minShowLabelRadian || !data.hasValue(idx)) {
Review comment:
I think `data.hasValue` should not be used here, because any dimension on a
certain `dataIndex` does not have value, the `data.hasValue` returns `false`,
despite that whether the dimension is used by this "pie series".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
