Hi Chris, I will try to do this, if I have any question, keep in touch!
Vino yang Thanks. 2018-03-20 17:32 GMT+08:00 Christofer Dutz <christofer.d...@c-ware.de>: > Ok, > > So I just added a new Annotation type to the Kafka module. > > org.apache.edgent.connectors.kafka.annotations.KafkaVersion > > It has a fromVersion and a toVersion attribute. Both should be optional so > just adding the annotation would have no effect (besides a few additional > CPU operations). The annotation can be applied to methods or classes (every > method then inherits this). I hope that's ok, because implementing this on > a parameter Level would make things extremely difficult. > > @vino yang With this you should be able to provide Kafka version > constraints to your code changes. Just tell me if something's missing or > needs to be done differently > > For now this annotation will have no effect as I haven't implemented the > Aspect for doing the checks, but I'll start working on that as soon as you > have annotated something. > > Chris > > Am 20.03.18, 10:11 schrieb "Christofer Dutz" <christofer.d...@c-ware.de>: > > Ok ... maybe I should add the Annotation prior to continuing my work > on the AWS connector ... > > > Chris > > Am 04.03.18, 08:10 schrieb "vino yang" <yanghua1...@gmail.com>: > > The reason is that Kafka 0.9+ provided a new consumer API which > has more > features and better performance. > > Just like Flink's implementation : > https://github.com/apache/flink/tree/master/flink-connectors. > > vinoyang > Thanks. > > > > >
