yuzhoumao commented on a change in pull request #369:
URL:
https://github.com/apache/incubator-eventmesh/pull/369#discussion_r640871501
##########
File path:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/AbstractLiteClient.java
##########
@@ -46,4 +53,22 @@ public LiteClientConfig getLiteClientConfig() {
public void shutdown() throws Exception {
logger.info("AbstractLiteClient shutdown");
}
+
+ public CloseableHttpClient setHttpClient() throws Exception {
+ if (!liteClientConfig.isUseTls()) {
+ return HttpClients.createDefault();
+ }
+ SSLContext sslContext = null;
+ try {
+ String protocol = System.getProperty("ssl.client.protocol",
"TLSv1.1");
Review comment:
I know it's outside the original intention of this PR, but is there any
particular reason we need to default to TLS 1.1 here?
would it be better if we default to TLS 1.2 instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
