jinrongluo commented on a change in pull request #369:
URL: 
https://github.com/apache/incubator-eventmesh/pull/369#discussion_r640900814



##########
File path: 
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/AbstractLiteClient.java
##########
@@ -46,4 +53,22 @@ public LiteClientConfig getLiteClientConfig() {
     public void shutdown() throws Exception {
         logger.info("AbstractLiteClient shutdown");
     }
+
+    public CloseableHttpClient setHttpClient() throws Exception {

Review comment:
       @ruanwenjun has a comment to in other part of my PR, mentioning not to 
wrap generic exception into EventMeshException. I am fine with either way, 
actually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to