AhahaGe commented on a change in pull request #571:
URL:
https://github.com/apache/incubator-eventmesh/pull/571#discussion_r736418518
##########
File path: CONTRIBUTING.md
##########
@@ -3,21 +3,6 @@
Welcome to EventMesh! This document is a guideline about how to contribute to
EventMesh. If you find something incorrect
or missing, please leave comments / suggestions.
-## Before you get started
-
-### Setting up your development environment
Review comment:
Because with ide, if we don't import it, we can't check code style. And
In some other part of this file, we have noticed that. So I suggest to delete
it.
Code review
All code should be well reviewed by one or more committers. Some principles:
Readability: Important code should be well-documented. Comply with our code
style.
Elegance: New functions, classes or components should be well-designed.
Testability: Important code should be well-tested (high unit test coverage).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
