ruanwenjun commented on pull request #571: URL: https://github.com/apache/incubator-eventmesh/pull/571#issuecomment-951843693
> > This is mandatory for contributor, if contributors hope to contribute code to EventMesh, they need to follow the code style rule in EventMesh. You can't remove this. > > If you have suggestions about the rules defined checkstyle you can discuss in #444, or send mail to [[email protected]](mailto:[email protected]). > > Because with ide, if we don't import it, we can't check code style. And In some other part of this file, we have noticed that. So I suggest to delete the step of Setting up your development environment. If we can supply a checkfile which can be loaded success, that's ok. > > Code review All code should be well reviewed by one or more committers. Some principles: > > Readability: Important code should be well-documented. Comply with our code style. Elegance: New functions, classes or components should be well-designed. Testability: Important code should be well-tested (high unit test coverage). This file can be loaded successful, if you follow the step describe in the doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
