li-xiao-shuang commented on code in PR #835:
URL:
https://github.com/apache/incubator-eventmesh/pull/835#discussion_r851913527
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshServer.java:
##########
@@ -101,18 +122,26 @@ public void start() throws Exception {
if (eventMeshHttpConfiguration != null &&
eventMeshHttpConfiguration.eventMeshServerSecurityEnable) {
acl.start();
}
-
+ // registry start
if (eventMeshTCPConfiguration != null
- && eventMeshTCPConfiguration.eventMeshTcpServerEnabled
- && eventMeshTCPConfiguration.eventMeshServerRegistryEnable) {
+ && eventMeshTCPConfiguration.eventMeshTcpServerEnabled
+ && eventMeshTCPConfiguration.eventMeshServerRegistryEnable) {
+ registry.start();
+ }
+ if (eventMeshHttpConfiguration != null &&
eventMeshHttpConfiguration.eventMeshServerRegistryEnable) {
+ registry.start();
+ }
+ if (eventMeshGrpcConfiguration != null &&
eventMeshGrpcConfiguration.eventMeshServerRegistryEnable) {
registry.start();
}
Review Comment:
Here we just reuse the existing format and register for each protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
