ruanwenjun commented on code in PR #835:
URL:
https://github.com/apache/incubator-eventmesh/pull/835#discussion_r851918767
##########
eventmesh-spi/src/main/java/org/apache/eventmesh/spi/EventMeshExtensionFactory.java:
##########
@@ -35,8 +35,7 @@
* The extension fetching factory, all extension plugins should be fetched by
this factory.
* And all the extension plugins defined in eventmesh should have {@link
EventMeshSPI} annotation.
*/
-public enum EventMeshExtensionFactory {
- ;
+public class EventMeshExtensionFactory {
Review Comment:
You need to add a private constructor and make this class final, this is [a
good pattern](https://codepumpkin.com/use-private-constructor-java/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
