HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1127119225
There is no exposed behavior in [org/apache/eventmesh/trace/api/config/ExporterConfiguration.java](https://github.com/apache/incubator-eventmesh/blob/master/eventmesh-trace-plugin/eventmesh-trace-api/src/main/java/org/apache/eventmesh/trace/api/config/ExporterConfiguration.java). Not sure whether it is necessary to make `initializeConfig()` and `loadProperties()` protected (package private), and add test for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
