HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1127442988
It seems that mocking a final class is [still a incubating feature](https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2#mock-the-unmockable-opt-in-mocking-of-final-classesmethods) of Mockito, which need a [extra file with single line](https://github.com/apache/incubator-eventmesh/blob/f7c49017a349d8d4453e3fab3b1419efa84f55f8/eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker) to enable this feature. However the additional file violate the [ci license check](https://github.com/apache/incubator-eventmesh/runs/6444747775?check_suite_focus=true), any possible to skip license check on this file ? Otherwise i may remove the unit test for [zipkinTrackService.shutdown()](https://github.com/apache/incubator-eventmesh/blob/f7c49017a349d8d4453e3fab3b1419efa84f55f8/eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/java/org/apache/eventmesh/trace/zipkin/ZipkinTraceServiceTest.java#L62-L73). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
