HoffmanZheng commented on PR #884:
URL: 
https://github.com/apache/incubator-eventmesh/pull/884#issuecomment-1134072242

   > Good catch. Right now, the scope of `eventmesh-common` in 
`eventmesh-sdk-java` is `implementation`, so if we want to use 
eventmesh-sdk-java in our app, we need to add the `eventmesh-common` to our 
dependency. We need to change the scope from `implementation` to api to solve 
this.
   > 
   > And I think we don't need to make a shawdow jar. cc @xwm1992
   
   Currently I'm trying to use the following script to generate a fat jar of 
[eventmesh-sdk-java], sometimes it works. Mark the PR work in progress.
   
   ```
   jar {
       from {
           configurations. runtimeClasspath.filter{ it.exists() }.collect { 
it.isDirectory() ? it : zipTree(it) }
       }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to