HoffmanZheng commented on code in PR #884:
URL:
https://github.com/apache/incubator-eventmesh/pull/884#discussion_r882343590
##########
eventmesh-sdk-java/build.gradle:
##########
@@ -50,10 +54,9 @@ dependencies {
implementation "io.grpc:grpc-protobuf:1.15.0"
implementation "io.grpc:grpc-stub:1.15.0"
implementation "com.google.protobuf:protobuf-java-util:3.5.1"
- compileOnly 'org.projectlombok:lombok:1.18.22'
+ api 'org.projectlombok:lombok:1.18.22'
Review Comment:
also make sense to me, seems the `eventmesh-example` uses that only for log.
it's not necessary to export to the users of `eventmesh-sdk-java`
https://github.com/apache/incubator-eventmesh/blob/c055e8324fd6b0c67055b2f4c6731f386acdb5a4/eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/sub/controller/SubController.java#L42
https://github.com/apache/incubator-eventmesh/blob/c055e8324fd6b0c67055b2f4c6731f386acdb5a4/eventmesh-examples/src/main/java/org/apache/eventmesh/http/demo/sub/controller/SubController.java#L56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
