kirinzhu commented on code in PR #990:
URL:
https://github.com/apache/incubator-eventmesh/pull/990#discussion_r918708253
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new
ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+
ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
Sorry, I am confused why you want to add this line. Could you please not
modify eventmesh-runtime? Generally, eventmesh-runtime is not encouraged to be
changed.
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new
ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+
ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
Please refer to what eventmesh-connector-rocketmq looks like, so that we
could merge your branch into master branch in the further future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
