mytang0 commented on code in PR #990:
URL:
https://github.com/apache/incubator-eventmesh/pull/990#discussion_r919585470
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new
ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+
ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
> Sorry, I am confused why you want to add this line. Could you please not
modify eventmesh-runtime? Generally, eventmesh-runtime is not encouraged to be
changed.
Because we use the configuration center for unified management of
configuration information, we hope to have a unified configuration reference,
instead of piecemeal configuration like eventmesh-connector-rocketmq. It is
really hard to understand from the perspective of redis-connector. Therefore,
I will remove this part of the function first, and then raise an issue to solve
the configuration problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
