jonyangx commented on code in PR #2834:
URL:
https://github.com/apache/incubator-eventmesh/pull/2834#discussion_r1062864135
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/WebhookUtil.java:
##########
@@ -65,8 +65,11 @@ public static boolean obtainDeliveryAgreement(final
CloseableHttpClient httpClie
final String allowedOrigin =
response.getLastHeader(ALLOWED_ORIGIN_HEADER).getValue();
return StringUtils.isEmpty(allowedOrigin)
|| "*".equals(allowedOrigin) ||
allowedOrigin.equalsIgnoreCase(requestOrigin);
+ } catch (IOException e) {
+ LOGGER.error("HTTP Options Method is not supported at the Delivery
Target: {}, "
+ + "unable to obtain the webhook delivery agreement.",
targetUrl, e);
}
-
+ return true;
Review Comment:
I think throws IOEXception is better than return true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
