----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30921/#review72260 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java <https://reviews.apache.org/r/30921/#comment118330> Please import individual classes that are needed by your test. Mass import is not ok. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java <https://reviews.apache.org/r/30921/#comment118334> why are we setting acl explicitly ? My understanding of this is that it should already have good values at this point. We tinker with acls only for authentication/authorization related tests. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java <https://reviews.apache.org/r/30921/#comment118336> Can you print expected and actual response as part of your assertion message ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java <https://reviews.apache.org/r/30921/#comment118337> Can you print expected and actual response as part of your assertion message ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java <https://reviews.apache.org/r/30921/#comment118340> same as above falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java <https://reviews.apache.org/r/30921/#comment118342> same as above - Raghav Gautam On Feb. 12, 2015, 1:26 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30921/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 1:26 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1021 > https://issues.apache.org/jira/browse/FALCON-1021 > > > Repository: falcon-git > > > Description > ------- > > A test needs to be added to test SLA for feeds corresponding to FALCON-721 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > cec7684 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30921/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
