> On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, > > line 68 > > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line68> > > > > why are we setting acl explicitly ? My understanding of this is that it > > should already have good values at this point. > > > > We tinker with acls only for authentication/authorization related tests.
Added it as an extra check. But i think it is handled by regression now. Will remove this in the new patch. > On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, > > line 127 > > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line127> > > > > Can you print expected and actual response as part of your assertion > > message ? Added validate function to handle the same. > On Feb. 12, 2015, 11:13 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java, > > line 152 > > <https://reviews.apache.org/r/30921/diff/1/?file=861653#file861653line152> > > > > Can you print expected and actual response as part of your assertion > > message ? Added validate function to handle the same. - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30921/#review72260 ----------------------------------------------------------- On Feb. 12, 2015, 9:26 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30921/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 9:26 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1021 > https://issues.apache.org/jira/browse/FALCON-1021 > > > Repository: falcon-git > > > Description > ------- > > A test needs to be added to test SLA for feeds corresponding to FALCON-721 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > cec7684 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30921/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
