-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31077/#review73525
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
<https://reviews.apache.org/r/31077/#comment119912>

    basic search patters like "new", "defintion", "W-E" etc should also be 
added.



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
<https://reviews.apache.org/r/31077/#comment119913>

    patters like "news" , "NewEntityDefinition", "new*" etc should also be added



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
<https://reviews.apache.org/r/31077/#comment119917>

    use LOGGER.debug



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
<https://reviews.apache.org/r/31077/#comment119907>

    since this method is not actually genration random entity names , its name 
as "getRandomName" is misleading. kindly change it to more appropriate.


- samarth gupta


On Feb. 16, 2015, 7:28 a.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31077/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 7:28 a.m.)
> 
> 
> Review request for Falcon and Raghav Gautam.
> 
> 
> Bugs: FALCON-1030
>     https://issues.apache.org/jira/browse/FALCON-1030
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> A test has to be added to search and list the entities based on the pattern 
> given by user. Based on FALCON-914
> 
> 
> Diffs
> -----
> 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31077/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>

Reply via email to