> On Feb. 23, 2015, 7:10 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java, > > line 183 > > <https://reviews.apache.org/r/31077/diff/1/?file=864797#file864797line183> > > > > since this method is not actually genration random entity names , its > > name as "getRandomName" is misleading. kindly change it to more appropriate.
Changed it to getPatternName() > On Feb. 23, 2015, 7:10 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java, > > line 154 > > <https://reviews.apache.org/r/31077/diff/1/?file=864797#file864797line154> > > > > use LOGGER.debug Done > On Feb. 23, 2015, 7:10 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java, > > line 131 > > <https://reviews.apache.org/r/31077/diff/1/?file=864797#file864797line131> > > > > patters like "news" , "NewEntityDefinition", "new*" etc should also be > > added Added "newss", "new*", "NewEntityDefinitions" patterns. Any other required ? > On Feb. 23, 2015, 7:10 a.m., samarth gupta wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java, > > line 120 > > <https://reviews.apache.org/r/31077/diff/1/?file=864797#file864797line120> > > > > basic search patters like "new", "defintion", "W-E" etc should also be > > added. Added "new", "defintion", "W-E", "NewEntityDefinition". Any other required? - PRAGYA ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31077/#review73525 ----------------------------------------------------------- On Feb. 16, 2015, 7:28 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31077/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 7:28 a.m.) > > > Review request for Falcon and Raghav Gautam. > > > Bugs: FALCON-1030 > https://issues.apache.org/jira/browse/FALCON-1030 > > > Repository: falcon-git > > > Description > ------- > > A test has to be added to search and list the entities based on the pattern > given by user. Based on FALCON-914 > > > Diffs > ----- > > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31077/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
