> On April 9, 2015, 5:12 a.m., Pallavi Rao wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java,
> > line 199
> > <https://reviews.apache.org/r/32946/diff/1/?file=920320#file920320line199>
> >
> > Why has this been removed?
It is on line 200-201:
Map<String, String> filterByFieldsValues =
getFilterByFieldsValues(filterBy);
validateEntityFilterByClause(filterByFieldsValues);
- Ying
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32946/#review79478
-----------------------------------------------------------
On April 8, 2015, 1:05 a.m., Ying Zheng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32946/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 1:05 a.m.)
>
>
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh,
> and Venkat Ranganathan.
>
>
> Bugs: Falcon-1121
> https://issues.apache.org/jira/browse/Falcon-1121
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> See parent JIRA Falcon-1095 for detailed descriptions:
> http://issues.apache.org/jira/browse/Falcon-1095
> Four changes in total:
> 1. Added API support: return feeds and processes if :entity-type is set to
> schedulable; change parameter for subsequence matching from "pattern" to
> "nameseq"; multi-keyword matching for entity tags with parameter "tagkey".
> 2. Added command line support.
> 3. Added unit tests.
> 4. Updated twiki.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 958ea62
> client/src/main/java/org/apache/falcon/client/FalconClient.java 15691a6
> client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d
> client/src/main/java/org/apache/falcon/resource/EntityList.java d43418c
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java
> 1c1c325
> docs/src/site/twiki/FalconCLI.twiki 22ffbe7
> docs/src/site/twiki/restapi/EntityList.twiki 5e11691
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
> c0df4d6
>
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
> f7c2f61
>
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
> 8bfc099
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java
> 6f75111
>
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java
> 261a9a9
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java bfad011
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java
> 280253d
>
> Diff: https://reviews.apache.org/r/32946/diff/
>
>
> Testing
> -------
>
> Unit tests passed. Also tested command line and using api calls.
>
>
> Thanks,
>
> Ying Zheng
>
>
