> On April 8, 2015, 8:59 p.m., Scott Preece wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java,
> > lines 570-573
> > <https://reviews.apache.org/r/32946/diff/1/?file=920319#file920319line570>
> >
> > Probably should state exactly what "filter by" means for each filter
> > type - for example,
> >
> > * @param tagKey Filter by tag keywords, separated by
> > comma; keep entity only if it has all given tags"
>
> Ying Zheng wrote:
> Thanks for suggestions, Scott. I changed to "Tag keywords to match,
> seperated by commma".
>
> Scott Preece wrote:
> Two things are still unclear - (1) What does "filter by" mean - does it
> mean matching entities are excluded or that they are included? (2) The
> filterTags and tagKey options take lists of values - are they ANDed or ORed -
> does the filter match only if all the tags/keys are present or does it match
> if any of them are present?
1) I think you were looking at the old diff patch. Could you refresh? Here is
the one I updated last week:
* @param nameSubsequence Name subsequence to match
* @param tagKeywords Tag keywords to match, separated by commma
* @param filterType Only return entities of this type
* @param filterTags Full tag matching, separated by comma
* @param filterBy Specific fields to match (i.e. TYPE, NAME,
STATUS, PIPELINES, CLUSTER)
2) They are all AND operations. This is documented in EntityList.twiki, which
explains the entity list API.
- Ying
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32946/#review79411
-----------------------------------------------------------
On April 22, 2015, 10:50 p.m., Ying Zheng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32946/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 10:50 p.m.)
>
>
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh,
> and Venkat Ranganathan.
>
>
> Bugs: Falcon-1121
> https://issues.apache.org/jira/browse/Falcon-1121
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> See parent JIRA Falcon-1095 for detailed descriptions:
> http://issues.apache.org/jira/browse/Falcon-1095
> Four changes in total:
> 1. Added API support: return feeds and processes if :entity-type is set to
> schedulable; change parameter for subsequence matching from "pattern" to
> "nameseq"; multi-keyword matching for entity tags with parameter "tagkeys".
> 2. Added command line support.
> 3. Added unit tests.
> 4. Updated twiki.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01
> client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6
> client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d
> client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195
> common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java
> b84371f
> docs/src/site/twiki/FalconCLI.twiki 0e42ae2
> docs/src/site/twiki/restapi/EntityList.twiki 08dd304
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java
> 25cb312
>
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java
> 6198c74
>
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
> 6ccfd09
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java
> 9b0dec5
>
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java
> 82a622c
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c
> webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java
> 280253d
>
> Diff: https://reviews.apache.org/r/32946/diff/
>
>
> Testing
> -------
>
> Unit tests passed. Also tested command line and using api calls.
>
>
> Thanks,
>
> Ying Zheng
>
>
