> On May 7, 2015, 4:55 p.m., Sowmya Ramesh wrote: > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java, > > line 282 > > <https://reviews.apache.org/r/33867/diff/4/?file=952329#file952329line282> > > > > Can you use @AfterClass annotation "@AfterClass: The annotated method > > will be run after all the test methods in the current class have been run" ? > > > > Since you are creating unique locations everything can be cleaned up > > after all the tests have run. Its a much cleaner way to handle the cleanup.
Agreed, fixed the patch. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33867/#review82831 ----------------------------------------------------------- On May 7, 2015, 3:12 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33867/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 3:12 p.m.) > > > Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan. > > > Bugs: Falcon-1195 > https://issues.apache.org/jira/browse/Falcon-1195 > > > Repository: falcon-git > > > Description > ------- > > testClusterWithOnlyStaging fails intermittently due to race condition in > creating working dir for cluster. This can be fixed by creating a different > working/staging dir for each test case. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 4555cb0 > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > 4920d03 > > Diff: https://reviews.apache.org/r/33867/diff/ > > > Testing > ------- > > Ran unit tests multiple times to verify the changes. > > > Thanks, > > Balu Vellanki > >
