> On May 7, 2015, 8:18 a.m., Ajay Yadava wrote: > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java, > > line 296 > > <https://reviews.apache.org/r/33867/diff/3/?file=951662#file951662line296> > > > > Seems like cleanupClusterLocations is a good candidate for @AfterMethod. > > Balu Vellanki wrote: > Minority of the tests create the staging and working dirs. So having > cleanupClusterLocations() in AfterMethod seems like overkill.
Talked to Sowmya and moved the cleanup to @AfterClass - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33867/#review82807 ----------------------------------------------------------- On May 7, 2015, 5:42 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33867/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 5:42 p.m.) > > > Review request for Falcon, Sowmya Ramesh and Venkat Ranganathan. > > > Bugs: Falcon-1195 > https://issues.apache.org/jira/browse/Falcon-1195 > > > Repository: falcon-git > > > Description > ------- > > testClusterWithOnlyStaging fails intermittently due to race condition in > creating working dir for cluster. This can be fixed by creating a different > working/staging dir for each test case. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 4555cb0 > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > 4920d03 > > Diff: https://reviews.apache.org/r/33867/diff/ > > > Testing > ------- > > Ran unit tests multiple times to verify the changes. > > > Thanks, > > Balu Vellanki > >
