> On Sept. 15, 2015, 3:52 a.m., Peeyush Bishnoi wrote: > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java, > > line 138 > > <https://reviews.apache.org/r/38387/diff/2/?file=1073236#file1073236line138> > > > > Instead of using static path like "/tmp", shall we use "temp" element > > value in cluster entity for validation.
/tmp always exists in HDFS, not so for /temp. For readonly, Falcon do not need to create any files. Falcon just has to verify that user can connect to namenode. So /tmp is better option. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38387/#review98988 ----------------------------------------------------------- On Sept. 15, 2015, 12:09 a.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38387/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 12:09 a.m.) > > > Review request for Falcon, Ajay Yadava and Sowmya Ramesh. > > > Bugs: FALCON-1343 > https://issues.apache.org/jira/browse/FALCON-1343 > > > Repository: falcon-git > > > Description > ------- > > A read/write endpoint is currently validated by creating a filesystem with > the endpoint url. > {code} > HadoopClientFactory.get().createProxiedFileSystem(conf); > {code} > > I confirmed with a HDFS team member that it is not sufficient validation. > Ideally check if the end user has access by doing atleast a list /tmp call > after creating proxiedFileSystem. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 5756f84 > common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a36623c > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > 638cef9 > common/src/test/resources/config/cluster/cluster-bad-write-endpoint.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/38387/diff/ > > > Testing > ------- > > Tested end2end, added a unit test. > > > Thanks, > > Balu Vellanki > >
