> On Sept. 15, 2015, 11:17 p.m., Sowmya Ramesh wrote: > > In ClusterEntityParser we have validateLocations for validate the locations > > passed in cluster entity. Isn't that same as this?
If the interface endpoints have a typo, the error thrown by validateLocations does not help users immediately pinpoint the source of problem. So I recommend having a very basic validation. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38387/#review99122 ----------------------------------------------------------- On Sept. 21, 2015, 11:38 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38387/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 11:38 p.m.) > > > Review request for Falcon, Ajay Yadava and Sowmya Ramesh. > > > Bugs: FALCON-1343 > https://issues.apache.org/jira/browse/FALCON-1343 > > > Repository: falcon-git > > > Description > ------- > > A read/write endpoint is currently validated by creating a filesystem with > the endpoint url. > {code} > HadoopClientFactory.get().createProxiedFileSystem(conf); > {code} > > I confirmed with a HDFS team member that it is not sufficient validation. > Ideally check if the end user has access by doing atleast a list /tmp call > after creating proxiedFileSystem. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 6bfcb98 > common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java 6179855 > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > 2bafac9 > common/src/test/resources/config/cluster/cluster-bad-write-endpoint.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/38387/diff/ > > > Testing > ------- > > Tested end2end, added a unit test. > > > Thanks, > > Balu Vellanki > >
