----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38669/#review100201 -----------------------------------------------------------
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 414) <https://reviews.apache.org/r/38669/#comment157358> nit: fully qualified name shouldn't be required I believe. common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 425) <https://reviews.apache.org/r/38669/#comment157356> Should we use getBasePath()? common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 431) <https://reviews.apache.org/r/38669/#comment157357> nit : Now that you have created a constant for the separator shouldn't we be using that here instead of hardcoding? common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 440) <https://reviews.apache.org/r/38669/#comment157359> nit: wouldn't separating these two scenarios in two different test cases make tests more granular and independent of each other? - Ajay Yadava On Sept. 23, 2015, 8:23 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38669/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 8:23 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1483 > https://issues.apache.org/jira/browse/FALCON-1483 > > > Repository: falcon-git > > > Description > ------- > > Utility method that the native scheduler requires. > > This is linked to https://reviews.apache.org/r/35724/. All review comments > there have been incorporated in the patch. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java ad41674 > common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java d022bae > > Diff: https://reviews.apache.org/r/38669/diff/ > > > Testing > ------- > > UT added. Manual testing done. > > > Thanks, > > Pallavi Rao > >
