> On Sept. 23, 2015, 8:34 a.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 708 > > <https://reviews.apache.org/r/38669/diff/1/?file=1082228#file1082228line708> > > > > ENTITY_MUTATION_TIME_SEPARATOR? > > Pallavi Rao wrote: > Wanted to keep it generic.. We could use the same separator if we want to > add another part to the dir name.
makes sense - sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38669/#review100167 ----------------------------------------------------------- On Sept. 24, 2015, 5:31 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38669/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 5:31 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1483 > https://issues.apache.org/jira/browse/FALCON-1483 > > > Repository: falcon-git > > > Description > ------- > > Utility method that the native scheduler requires. > > This is linked to https://reviews.apache.org/r/35724/. All review comments > there have been incorporated in the patch. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java ad41674 > common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java d022bae > > Diff: https://reviews.apache.org/r/38669/diff/ > > > Testing > ------- > > UT added. Manual testing done. > > > Thanks, > > Pallavi Rao > >
