> On Sept. 28, 2015, 7:08 p.m., Ajay Yadava wrote: > > messaging/pom.xml, line 96 > > <https://reviews.apache.org/r/38800/diff/1/?file=1085743#file1085743line96> > > > > Do we really need everything in activemq-all? Is this a mandatory > > requirement to fix the issue being described in JIRA? > > Peeyush Bishnoi wrote: > For the given exception, we need to upgrade the activemq to 5.12.0. > activemq-core is within activemq-all which is in version 5.12.0. > > Ajay Yadava wrote: > My concern is that activemq-all will contain lot of other things which we > don't need. Can we avoid including those dependencies and continue to use > just upgraded version of activemq-core, will that not solve the issue?
I too have thought similarly and tried to avoid classes which we don't require. But as I have mentioned, for version 5.12.0 activemq-all is only available that inclusively contain classes for activemq-core jar file and it's dependencies. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38800/#review100844 ----------------------------------------------------------- On Sept. 28, 2015, 9:14 a.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38800/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 9:14 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1491 > https://issues.apache.org/jira/browse/FALCON-1491 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1491: Update ActiveMQ version to 5.12 > > > Diffs > ----- > > addons/hivedr/pom.xml fc04f20 > common/src/main/resources/startup.properties 9db460c > messaging/pom.xml 6528278 > > messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java > 5bbcc87 > pom.xml 8127b46 > rerun/pom.xml b07e4e9 > src/conf/startup.properties 8f3bc35 > test-tools/hadoop-webapp/pom.xml eea00dc > unit/src/main/resources/startup.properties 4207ab9 > webapp/pom.xml a4d5a8d > > Diff: https://reviews.apache.org/r/38800/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Peeyush Bishnoi > >
