----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38800/#review101450 -----------------------------------------------------------
addons/hivedr/pom.xml (line 96) <https://reviews.apache.org/r/38800/#comment158835> No new exclusions required? common/src/main/resources/startup.properties (line 56) <https://reviews.apache.org/r/38800/#comment158836> May be activemq-client is sufficient here. See related comment below. messaging/pom.xml (line 96) <https://reviews.apache.org/r/38800/#comment158838> activemq-client is sufficient for compilation of this package. Only tests use broker. So, can we just use activemq-all with test scope and activemq-client with compile scope? messaging/pom.xml (line 121) <https://reviews.apache.org/r/38800/#comment158839> Repeated exclusion pom.xml (line 757) <https://reviews.apache.org/r/38800/#comment158834> Exclusion is repeated. rerun/pom.xml (line 92) <https://reviews.apache.org/r/38800/#comment158842> Is activemq-client is sufficient for compile and test of this package? test-tools/hadoop-webapp/pom.xml (line 192) <https://reviews.apache.org/r/38800/#comment158843> Same comment as above may be use appropriate packages with different scopes? - Pallavi Rao On Oct. 1, 2015, 1:23 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38800/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 1:23 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1491 > https://issues.apache.org/jira/browse/FALCON-1491 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1491: Update ActiveMQ version to 5.12 > > > Diffs > ----- > > addons/hivedr/pom.xml fc04f20 > common/src/main/resources/startup.properties 9db460c > messaging/pom.xml 6528278 > > messaging/src/test/java/org/apache/falcon/messaging/JMSMessageConsumerTest.java > 5bbcc87 > pom.xml 8127b46 > rerun/pom.xml b07e4e9 > src/conf/startup.properties 8f3bc35 > test-tools/hadoop-webapp/pom.xml eea00dc > unit/src/main/resources/startup.properties 4207ab9 > webapp/pom.xml a4d5a8d > > Diff: https://reviews.apache.org/r/38800/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Peeyush Bishnoi > >
