-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37297/#review101963
-----------------------------------------------------------



prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java (line 
159)
<https://reviews.apache.org/r/37297/#comment159477>

    From the functionality, it looks more like a PUT method instead of GET. See 
details:
    
    http://www.restapitutorial.com/lessons/httpmethods.html
    
    The HTTP GET method is used to **read** (or retrieve) a representation of a 
resource.
    
    PUT is most-often utilized for **update** capabilities, PUT-ing to a known 
resource URI with the request body containing the newly-updated representation 
of the original resource.


- Ying Zheng


On Aug. 10, 2015, 2:29 p.m., Balu Vellanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37297/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 2:29 p.m.)
> 
> 
> Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan.
> 
> 
> Bugs: FALCON-1316
>     https://issues.apache.org/jira/browse/FALCON-1316
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> API to get authenticated user
> API to clear hadoop.auth cookie
> Add property that says if auth is enabled into admin/version API
> Allow non-admin users access above apis.
> Unit tests.
> 
> 
> Diffs
> -----
> 
>   
> common/src/main/java/org/apache/falcon/security/DefaultAuthorizationProvider.java
>  449be80 
>   prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java 
> 50b668c 
>   prism/src/test/java/org/apache/falcon/resource/admin/AdminResourceTest.java 
> PRE-CREATION 
>   
> prism/src/test/java/org/apache/falcon/resource/admin/MockHttpServletResponse.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37297/diff/
> 
> 
> Testing
> -------
> 
> End2End testing done on multiple operating systems.
> 
> 
> Thanks,
> 
> Balu Vellanki
> 
>

Reply via email to