> On Oct. 9, 2015, 6:38 a.m., Ajay Yadava wrote: > > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java, > > line 159 > > <https://reviews.apache.org/r/37297/diff/1/?file=1036331#file1036331line159> > > > > Isn't this more like a POST action?
This was brought up by Ying and will be addressed in a separate Jira. > On Oct. 9, 2015, 6:38 a.m., Ajay Yadava wrote: > > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java, > > line 176 > > <https://reviews.apache.org/r/37297/diff/1/?file=1036331#file1036331line176> > > > > Can you please elaborate on motivation for this API? Isn't the response > > for it always deduced from request parameters and hence already available > > to client? Not sure about the kerberos case though. Exactly, need this to help UI get the authenticated user in secure vs non-secure setups. > On Oct. 9, 2015, 6:38 a.m., Ajay Yadava wrote: > > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java, > > line 170 > > <https://reviews.apache.org/r/37297/diff/1/?file=1036331#file1036331line170> > > > > I think returning HTTP Status 204 might be sufficient for your use > > cases, right? Yes, there is no need to return any text. Just returning 204 would suffice. - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37297/#review98043 ----------------------------------------------------------- On Aug. 10, 2015, 2:29 p.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37297/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 2:29 p.m.) > > > Review request for Falcon, Ajay Yadava, Sowmya Ramesh, and Venkat Ranganathan. > > > Bugs: FALCON-1316 > https://issues.apache.org/jira/browse/FALCON-1316 > > > Repository: falcon-git > > > Description > ------- > > API to get authenticated user > API to clear hadoop.auth cookie > Add property that says if auth is enabled into admin/version API > Allow non-admin users access above apis. > Unit tests. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/security/DefaultAuthorizationProvider.java > 449be80 > prism/src/main/java/org/apache/falcon/resource/admin/AdminResource.java > 50b668c > prism/src/test/java/org/apache/falcon/resource/admin/AdminResourceTest.java > PRE-CREATION > > prism/src/test/java/org/apache/falcon/resource/admin/MockHttpServletResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37297/diff/ > > > Testing > ------- > > End2End testing done on multiple operating systems. > > > Thanks, > > Balu Vellanki > >
