> On Nov. 17, 2015, 4:10 a.m., Pallavi Rao wrote: > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java, > > line 1668 > > <https://reviews.apache.org/r/40357/diff/1/?file=1126847#file1126847line1668> > > > > We are making 2 assumptions here: > > 1. If there is no error code, then the workflow was killed by the user. > > 2. The user-action is only 1 level deep. Meaning the user workflow has > > no sub-workflows. > > > > Correct? > > It is fine. May be just call it out in a comment?
Yes. 1) No error code in any of the actions would mean its killed. 2) I will comment out the same mentioning the check is done till level one. We may not have to worry on this once we get fix from oozie to propogate the status from actions to workflow level to coorinator action level. Will comment out them. > On Nov. 17, 2015, 4:10 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, > > line 137 > > <https://reviews.apache.org/r/40357/diff/1/?file=1126843#file1126843line137> > > > > Nit : IsWorkflowKilledByUser or IsWorkflowKilledManually may be better Acked. Thought of using IsWorkflowKilledByUser, but same method is getting called from workflow engine. Will keep it IsWorkflowKilledManually. > On Nov. 17, 2015, 4:10 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java, > > line 238 > > <https://reviews.apache.org/r/40357/diff/1/?file=1126844#file1126844line238> > > > > Shouldn't we let the listener of the notification decide whether or not > > to process the message? > > > > RetryHandler might want to ignore "user killed" instances, but, > > MetadataService might want to consume it and add it to the Graph DB. Acked. Makes sense, I will make the necessary changes and update the patch. - sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40357/#review106792 ----------------------------------------------------------- On Nov. 16, 2015, 6:37 p.m., sandeep samudrala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40357/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 6:37 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1597 > https://issues.apache.org/jira/browse/FALCON-1597 > > > Repository: falcon-git > > > Description > ------- > > As of now falcon doesn't distinguish between kill(failure in some form) and > manual kill. In case of an instance being a manual kill, falcon should stop > retrying on that instance. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java > 899165b > > common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java > 9d96fa3 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 8b3460a > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 4094556 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7262964 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > 8dcf3a5 > > Diff: https://reviews.apache.org/r/40357/diff/ > > > Testing > ------- > > Manual Testing done to check for instances only those failed get retried. > > > Thanks, > > sandeep samudrala > >
