> On Nov. 18, 2015, 1:37 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, > > line 140 > > <https://reviews.apache.org/r/40357/diff/4/?file=1127846#file1127846line140> > > > > nit: Can you please separate the getValues calls on separate lines for > > readability?
acked. > On Nov. 18, 2015, 1:37 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, > > line 368 > > <https://reviews.apache.org/r/40357/diff/4/?file=1127851#file1127851line368> > > > > nit: UnsupportedOperationException might be more suitable for this case > > and it will also help in distinguishing unimplemented methods from > > underlying errors as well. Makes sense. I will change it to the same. > On Nov. 18, 2015, 1:37 a.m., Ajay Yadava wrote: > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java, > > line 1672 > > <https://reviews.apache.org/r/40357/diff/4/?file=1127849#file1127849line1672> > > > > nit: you can reuse the client from above Acked. Will reuse the client. > On Nov. 18, 2015, 1:37 a.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, > > line 142 > > <https://reviews.apache.org/r/40357/diff/4/?file=1127846#file1127846line142> > > > > Did you mean Exception instead of just FalconException or are you > > interested in catching only the error from FalconWorkflowEngine? I mean to catch exception from isWorkflowKilledByUser, which is thrown out as Falcon Exception, handling exceptions from both FalconWorkflowEngine and OozieWorkflowEngine. - sandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40357/#review106854 ----------------------------------------------------------- On Nov. 17, 2015, 6:30 a.m., sandeep samudrala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40357/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 6:30 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1597 > https://issues.apache.org/jira/browse/FALCON-1597 > > > Repository: falcon-git > > > Description > ------- > > As of now falcon doesn't distinguish between kill(failure in some form) and > manual kill. In case of an instance being a manual kill, falcon should stop > retrying on that instance. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java > 899165b > > common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java > 9d96fa3 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 8b3460a > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 7262964 > rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java > 7aa094a > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > 8dcf3a5 > > Diff: https://reviews.apache.org/r/40357/diff/ > > > Testing > ------- > > Manual Testing done to check for instances only those failed get retried. > > > Thanks, > > sandeep samudrala > >
