----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40388/#review107341 -----------------------------------------------------------
.reviewboardrc (line 1) <https://reviews.apache.org/r/40388/#comment166671> It will be nice to add this as part of a separate JIRA so that others are also aware of this new feature and can express their opinion on it. cli/pom.xml (line 10) <https://reviews.apache.org/r/40388/#comment166429> nit: trailing spaces. cli/pom.xml (line 135) <https://reviews.apache.org/r/40388/#comment166432> Is this really required? cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 100) <https://reviews.apache.org/r/40388/#comment166435> nit: cmdline part might need to be edited out, if we are no longer reading from cmdline. - Ajay Yadava On Nov. 18, 2015, 8:31 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40388/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 8:31 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1608 > https://issues.apache.org/jira/browse/FALCON-1608 > > > Repository: falcon-git > > > Description > ------- > > Adding code for early review. > 1. Need to reduce dependencies, right now all are copied from client module. > Will do once I'm able to get a local server instance running. > 2. Have added `.reviewboardrc` file just like > https://github.com/apache/lens/blob/master/.reviewboardrc and > https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the > contributers to create review requests quickly using tools like > http://github.com/prongs/apache-dev-tool > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > cli/pom.xml PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java > PRE-CREATION > > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java > PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java > PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java > PRE-CREATION > cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION > client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d > pom.xml 6f2c4801655a0ad1f7a15c5adce3dc79ef76560a > > Diff: https://reviews.apache.org/r/40388/diff/ > > > Testing > ------- > > http://showterm.io/d15a549584556b4c5a02a > > > Thanks, > > Rajat Khandelwal > >
