> On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote: > > .reviewboardrc, line 1 > > <https://reviews.apache.org/r/40388/diff/2/?file=1129250#file1129250line1> > > > > It will be nice to add this as part of a separate JIRA so that others > > are also aware of this new feature and can express their opinion on it.
Created FALCON-1634 > On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote: > > cli/pom.xml, line 10 > > <https://reviews.apache.org/r/40388/diff/2/?file=1129251#file1129251line10> > > > > nit: trailing spaces. Fixed. > On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote: > > cli/pom.xml, line 135 > > <https://reviews.apache.org/r/40388/diff/2/?file=1129251#file1129251line135> > > > > Is this really required? removed > On Nov. 22, 2015, 11:21 p.m., Ajay Yadava wrote: > > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java, > > line 100 > > <https://reviews.apache.org/r/40388/diff/2/?file=1129252#file1129252line100> > > > > nit: cmdline part might need to be edited out, if we are no longer > > reading from cmdline. edited. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40388/#review107341 ----------------------------------------------------------- On Nov. 23, 2015, 10:23 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40388/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 10:23 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1608 > https://issues.apache.org/jira/browse/FALCON-1608 > > > Repository: falcon-git > > > Description > ------- > > Adding code for early review. > 1. Need to reduce dependencies, right now all are copied from client module. > Will do once I'm able to get a local server instance running. > 2. Have added `.reviewboardrc` file just like > https://github.com/apache/lens/blob/master/.reviewboardrc and > https://github.com/apache/hive/blob/master/.reviewboardrc, This helps the > contributers to create review requests quickly using tools like > http://github.com/prongs/apache-dev-tool > > > Diffs > ----- > > cli/pom.xml PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java > PRE-CREATION > > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java > PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconBanner.java PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconHistoryFileProvider.java > PRE-CREATION > cli/src/main/java/org/apache/falcon/cli/skel/FalconPromptProvider.java > PRE-CREATION > cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml PRE-CREATION > client/pom.xml d54fabfa4f722559be9e683996042653ce904a4d > pom.xml fad890289396723d29e6e40f3bea8606e380be47 > > Diff: https://reviews.apache.org/r/40388/diff/ > > > Testing > ------- > > http://showterm.io/d15a549584556b4c5a02a > > > Thanks, > > Rajat Khandelwal > >
