> On Dec. 4, 2015, 5:08 p.m., sandeep samudrala wrote: > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java, > > line 65 > > <https://reviews.apache.org/r/40892/diff/1/?file=1152599#file1152599line65> > > > > Can you use calendar rather than DateUtils? > > Balu Vellanki wrote: > Agreed, I will make this change.
DateUtils is cleaner to use when working with java.util.Date objects, it is better to use Calendar when working with calendar instances. Since we are using Date class, dont you think it is better to use DateUtils? - Balu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40892/#review108995 ----------------------------------------------------------- On Dec. 3, 2015, 4:39 a.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40892/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 4:39 a.m.) > > > Review request for Falcon and Venkat Ranganathan. > > > Bugs: Falcon-1644 > https://issues.apache.org/jira/browse/Falcon-1644 > > > Repository: falcon-git > > > Description > ------- > > Here is a sample feed validity. > > <cluster name="primaryCluster" type="source"> > <validity start="2015-10-30T01:00Z" end="2015-10-30T10:00Z"/> > <retention limit="hours(10)" action="delete"/> > </cluster> > > In the above example, the validity time is "the time interval when the feed > is valid on this cluster". After the validity time ends, falcon is not > expected to perform any operations on the feed. The retention job for this > feed will be run from validity start time up to validity end time, and will > delete any feed instances older than 10 hours. Some instances of Feed will > never be deleted. In the above example, feed instances at between > 2015-10-30T00:00Z and 2015-10-30T10:00Z will never be deleted. > Ideally, the retention coordinator job should run from "validity start time" > up to "validity end time + retention age limit" to ensure all instances are > handled. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java > 69ca2c3 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > d034b1a > > Diff: https://reviews.apache.org/r/40892/diff/ > > > Testing > ------- > > End2End testing done to ensure retention coord endtime is set to "validity > end time + retention age limit" > > > Thanks, > > Balu Vellanki > >
