> On Dec. 4, 2015, 11:45 p.m., Ajay Yadava wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1015 > > <https://reviews.apache.org/r/40892/diff/1/?file=1152598#file1152598line1015> > > > > There is a FeedHelper method "getRetentionFrequency". You need to use > > that method. > > Balu Vellanki wrote: > Yes, I will use this method in FeedHelper. > > Balu Vellanki wrote: > @Ajay : The method "getRetentionFrequency" returns the frequency at which > retention coord should run. getRetentionLimitInSeconds method returns the > actual time limit upto which files should be retained. These two are > different and hence I will have to use getRetentionLimitInSeconds.
The correct position for that comment was the line below it, but I couldn't comment there as there was already another comment on that line. Intention was to highlight that in getRetentionLimitInSeconds you need to use FeedHelper's method, as getting retention frequency for a cluster is not as straight forward as ```feedCluster.getLifecycle().getRetentionStage().getFrequency();``` - Ajay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40892/#review109054 ----------------------------------------------------------- On Dec. 3, 2015, 4:39 a.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40892/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 4:39 a.m.) > > > Review request for Falcon and Venkat Ranganathan. > > > Bugs: Falcon-1644 > https://issues.apache.org/jira/browse/Falcon-1644 > > > Repository: falcon-git > > > Description > ------- > > Here is a sample feed validity. > > <cluster name="primaryCluster" type="source"> > <validity start="2015-10-30T01:00Z" end="2015-10-30T10:00Z"/> > <retention limit="hours(10)" action="delete"/> > </cluster> > > In the above example, the validity time is "the time interval when the feed > is valid on this cluster". After the validity time ends, falcon is not > expected to perform any operations on the feed. The retention job for this > feed will be run from validity start time up to validity end time, and will > delete any feed instances older than 10 hours. Some instances of Feed will > never be deleted. In the above example, feed instances at between > 2015-10-30T00:00Z and 2015-10-30T10:00Z will never be deleted. > Ideally, the retention coordinator job should run from "validity start time" > up to "validity end time + retention age limit" to ensure all instances are > handled. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java d601c5d > > oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionCoordinatorBuilder.java > 69ca2c3 > > oozie/src/test/java/org/apache/falcon/oozie/feed/OozieFeedWorkflowBuilderTest.java > d034b1a > > Diff: https://reviews.apache.org/r/40892/diff/ > > > Testing > ------- > > End2End testing done to ensure retention coord endtime is set to "validity > end time + retention age limit" > > > Thanks, > > Balu Vellanki > >
