[
https://issues.apache.org/jira/browse/FALCON-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050256#comment-15050256
]
sandeep samudrala commented on FALCON-1656:
-------------------------------------------
minor nit. retentionStage!=null is being checked twice each time, which can be
pushed up.
+1 other than that.
> Improve FeedHelper:getRetentionFrequency method
> -----------------------------------------------
>
> Key: FALCON-1656
> URL: https://issues.apache.org/jira/browse/FALCON-1656
> Project: Falcon
> Issue Type: Improvement
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: FALCON-1656.patch
>
>
> There are some edge cases that need to be handled so that it can be used by
> code outside lifecycle builders.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)