[
https://issues.apache.org/jira/browse/FALCON-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050381#comment-15050381
]
Peeyush Bishnoi commented on FALCON-1656:
-----------------------------------------
Patch looks good.
Initially variable retentionFrequency is getting set to "null" and also it is
getting returned from the function getRetentionFrequency. Is null check not
required to avoid NPE, wherever this variable is getting used.
> Improve FeedHelper:getRetentionFrequency method
> -----------------------------------------------
>
> Key: FALCON-1656
> URL: https://issues.apache.org/jira/browse/FALCON-1656
> Project: Falcon
> Issue Type: Improvement
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: FALCON-1656.patch
>
>
> There are some edge cases that need to be handled so that it can be used by
> code outside lifecycle builders.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)