> On Dec. 14, 2015, 4:34 p.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java, line 1021 > > <https://reviews.apache.org/r/41339/diff/1/?file=1162237#file1162237line1021> > > > > There is a small issue with getRetention().getLimit() w.r.t default > > frequency. > > Can you change this method to call > > > > getRetentionFrequency(Feed feed, String clusterName) > > > > from this api?
@Sandeep, what is the issue? - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41339/#review110250 ----------------------------------------------------------- On Dec. 14, 2015, 10:17 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41339/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 10:17 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1617 > https://issues.apache.org/jira/browse/FALCON-1617 > > > Repository: falcon-git > > > Description > ------- > > Currently on enabling SLA monitoring it doesn't consider instances which had > nominal time in past for SLA monitoring. With this JIRA we would like to > enable this. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 29daff3 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > b302539 > > Diff: https://reviews.apache.org/r/41339/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
