> On Dec. 14, 2015, 5:17 p.m., Ajay Yadava wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 330 > > <https://reviews.apache.org/r/41339/diff/1/?file=1162238#file1162238line330> > > > > I think your code is not rebased on the latest patch. This method has > > been renamed.
I have rebased the patch. "getRetentionFrequency" is the name of the new method that I have created. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41339/#review110257 ----------------------------------------------------------- On Dec. 14, 2015, 10:17 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41339/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 10:17 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1617 > https://issues.apache.org/jira/browse/FALCON-1617 > > > Repository: falcon-git > > > Description > ------- > > Currently on enabling SLA monitoring it doesn't consider instances which had > nominal time in past for SLA monitoring. With this JIRA we would like to > enable this. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java 29daff3 > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java > b302539 > > Diff: https://reviews.apache.org/r/41339/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
