----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40817/#review110611 -----------------------------------------------------------
Although there is base test class and test for FalconConnectionCommands, I didn't find any tests for EntityCommands. I am assuming it will be available in the final patch. cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java (line 117) <https://reviews.apache.org/r/40817/#comment170563> nit: spacing between functions. cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java (line 59) <https://reviews.apache.org/r/40817/#comment170562> Why is this command required? cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java (line 49) <https://reviews.apache.org/r/40817/#comment170569> Is this complete list of EntityCommands? I couldn't find commands like entity defintion, hence wondering. client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 64) <https://reviews.apache.org/r/40817/#comment170574> Type of the entity. Valid entity types are: cluster, feed, process and datasource. client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 70) <https://reviews.apache.org/r/40817/#comment170573> Should be "Name of the entity, recommended but not mandatory to be unique." client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 48) <https://reviews.apache.org/r/40817/#comment170564> nit: Update an entity client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 53) <https://reviews.apache.org/r/40817/#comment170565> nit: Submits "an" entity client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 55) <https://reviews.apache.org/r/40817/#comment170566> nit: Validates an entity. client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 88) <https://reviews.apache.org/r/40817/#comment170567> Where is this method used in the new framework? - Ajay Yadava On Dec. 1, 2015, 8:21 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40817/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 8:21 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1609 > https://issues.apache.org/jira/browse/FALCON-1609 > > > Repository: falcon-git > > > Description > ------- > > putting for early review > > > Diffs > ----- > > cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java > b7fa4cd524bfcd50ac260dadc2a1f94021b3df03 > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java > dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0 > > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java > cabe5a8083daf90456636d3378e410e3d95a4ada > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java > 6e091efcbe26ff7df7a3fe52e33b20f781b8d785 > cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java > PRE-CREATION > > cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java > PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java > 24f230ae66ba710945be76d176fbdbdbbcb3721c > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java > cb39a2fe95beae32dee930afb9bb78d85ebb58ea > client/src/main/java/org/apache/falcon/client/FalconClient.java > b4b176224554fb5a86ebca2bcced980dc84d2dd6 > > Diff: https://reviews.apache.org/r/40817/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
