> On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote: > > Although there is base test class and test for FalconConnectionCommands, I > > didn't find any tests for EntityCommands. I am assuming it will be > > available in the final patch.
Yes. Just wanted someone to check the approach early on. Since the same approach will be used in the all of entity commands, instance commands etc. You haven't mentioned any issues with the approach, hence I'll go ahead. I'm basically extracting commands, their options and their descriptions from the descriptions provided in the current CLI. Wherever required, I'm extracting `static final String` objects so that I can static import them in the new CLI. This will ensure that the two CLI's can co-exist with (almost) same commands. The co-existence period may(or not) be short, but I believe it's important for them to be in sync. And later when we want to deprecate the old CLI, we can just keep the `static final String` constants dumping everything else. > On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote: > > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java, > > line 59 > > <https://reviews.apache.org/r/40817/diff/1/?file=1149586#file1149586line59> > > > > Why is this command required? Don't worry about that, I'll remove it. So far it's just a WIP patch. > On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote: > > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java, > > line 49 > > <https://reviews.apache.org/r/40817/diff/1/?file=1149587#file1149587line49> > > > > Is this complete list of EntityCommands? I couldn't find commands like > > entity defintion, hence wondering. Not complete, Work in progress. > On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java, line 97 > > <https://reviews.apache.org/r/40817/diff/1/?file=1149591#file1149591line97> > > > > Where is this method used in the new framework? It's not used. > On Dec. 16, 2015, 9:54 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java, line 55 > > <https://reviews.apache.org/r/40817/diff/1/?file=1149591#file1149591line55> > > > > nit: Validates an entity. Just copied the old description. Guess that was wrong :) - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40817/#review110611 ----------------------------------------------------------- On Dec. 1, 2015, 1:51 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40817/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 1:51 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1609 > https://issues.apache.org/jira/browse/FALCON-1609 > > > Repository: falcon-git > > > Description > ------- > > putting for early review > > > Diffs > ----- > > cli/src/main/java/org/apache/falcon/cli/FalconCLIRuntimeException.java > b7fa4cd524bfcd50ac260dadc2a1f94021b3df03 > cli/src/main/java/org/apache/falcon/cli/commands/BaseFalconCommands.java > dbd28fb74e2aaeedc94ed4ee43e688ea9efb15b0 > > cli/src/main/java/org/apache/falcon/cli/commands/FalconConnectionCommands.java > cabe5a8083daf90456636d3378e410e3d95a4ada > cli/src/main/java/org/apache/falcon/cli/commands/FalconEntityCommands.java > 6e091efcbe26ff7df7a3fe52e33b20f781b8d785 > cli/src/test/java/org/apache/falcon/cli/commands/FalconCLITest.java > PRE-CREATION > > cli/src/test/java/org/apache/falcon/cli/commands/FalconConnectionCommandsTest.java > PRE-CREATION > client/src/main/java/org/apache/falcon/cli/FalconCLI.java > 24f230ae66ba710945be76d176fbdbdbbcb3721c > client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java > cb39a2fe95beae32dee930afb9bb78d85ebb58ea > client/src/main/java/org/apache/falcon/client/FalconClient.java > b4b176224554fb5a86ebca2bcced980dc84d2dd6 > > Diff: https://reviews.apache.org/r/40817/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
