----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41400/#review110622 -----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 60) <https://reviews.apache.org/r/41400/#comment170581> Name it FeedSLAMonitoringTest falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 80) <https://reviews.apache.org/r/41400/#comment170586> SchedulableEntityInstance has already compareTo method please use it. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 81) <https://reviews.apache.org/r/41400/#comment170587> Looks like tags is missing in compareTo you can add it over there if required falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 107) <https://reviews.apache.org/r/41400/#comment170599> Can you add description to this method , what are trying to setup ? falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 152) <https://reviews.apache.org/r/41400/#comment170603> is it possible to split these method into different methods falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 153) <https://reviews.apache.org/r/41400/#comment170606> Please split into diffeernt tests if one test depends on other we can use dependson anotation falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 165) <https://reviews.apache.org/r/41400/#comment170608> Make class variable noOfFeeds and use in for loop across places; falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 184) <https://reviews.apache.org/r/41400/#comment170611> It should be 60 right ? otherwise waiting 10 minutes is so long falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 186) <https://reviews.apache.org/r/41400/#comment170613> Can you move this method and make arguments startTime and endTime and return SchedulableEntityInstanceResult. Since it used across multiple places falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 220) <https://reviews.apache.org/r/41400/#comment170616> Move this also to method falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java (line 231) <https://reviews.apache.org/r/41400/#comment170617> Correct me, if i am wrong you are testing basic scenario and delete right ? Can you also add case for update if possible. - pavan kumar kolamuri On Dec. 15, 2015, 2:48 p.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41400/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 2:48 p.m.) > > > Review request for Falcon and Ajay Yadava. > > > Bugs: FALCON-1566 > https://issues.apache.org/jira/browse/FALCON-1566 > > > Repository: falcon-git > > > Description > ------- > > Add test for SLA monitoring API > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > e406cae > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java > 55e862c > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > ccd083b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSLATest.java > 28ddbd7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessSLATest.java > f4c9b30 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLAMonitoring.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/FeedSLATest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SLA/ProcessSLATest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41400/diff/ > > > Testing > ------- > > Tetsed in distributed mode. > > > Thanks, > > PRAGYA MITTAL > >
